Add ESM + CJS support for live-compositor and @live-compositor/core
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkozyra95
force-pushed
the
@wkozyra95/ts-sdk-add-esm-support
branch
2 times, most recently
from
1cf896b
to
bb1dc6c
Compare
wkozyra95
force-pushed
the
@wkozyra95/ts-sdk-add-esm-support
branch
from
bb1dc6c
to
3c9fb1b
Compare
wkozyra95
commented
Oct 1, 2024
| @@ -23,14 +23,5 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "live-compositor": "^0.1.0" | |||
| }, | |||
| "nx": { | |||
| "targets": { | |||
There was a problem hiding this comment.
I run npm run build often in root and this was very anoying
wkozyra95
commented
Oct 1, 2024
| @@ -16,6 +17,17 @@ | |||
| "tsconfig.json" | |||
| ] | |||
| }, | |||
| "settings": { | |||
| "import/parsers": { | |||
There was a problem hiding this comment.
By default eslint-plugin-import can't detect correctly exports section to detect esm, this seems to resolve the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For node we usually want to support CJS modules, but for projects like vite ESM seems to be needed. This PR builds
live-compositorand@live-compositor/corepackages to both esm and cjs